IGNORE `prefers-color-scheme` article for web.dev by tomayac · Pull Request #929 · GoogleChrome/web.dev

tomayac · 2019-05-23T14:27:07Z

This pull request adds a new:

Guide(s) 📘
Codelab(s) 🔬

Have you read the wiki on writing a guide or a codelab?

Done! 🍰(but adhering is WIP)

Does your content tell a user how to fix a Lighthouse audit?
Have you added the Lighthouse audit ID to your YAML?

My changes do not mention Lighthouse audits. 🙅‍♂️
I have added the Lighthouse audit IDs to my content. 👍

Does your content reference any Glitch projects?
Have you read the wiki on working with Glitch?
Have you added the Glitch project to our team page?

My changes do not contain any Glitches. 🙅‍♂️
I have read the wiki on working with Glitch. 🍰
I have added my Glitches to the team page. 👏

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

* Adds guidance about error boundaries * Update src/site/content/en/react/code-splitting-suspense/index.md Co-Authored-By: Houssein Djirdeh <houssein.djirdeh@gmail.com> * Update src/site/content/en/react/code-splitting-suspense/index.md Co-Authored-By: Houssein Djirdeh <houssein.djirdeh@gmail.com> * Add jeffposnick

robdodson

Started adding comments and then noticed this was a draft PR.
Give me a shout when you're ready for a review :)

robdodson · 2019-05-23T18:17:51Z

+date: 2019-05-23
+hero: macosx.png
+alt: macOS X Dark Mode preferences.
+description: |


need a description so it'll appear in search.

robdodson · 2019-05-23T18:18:32Z

+alt: macOS X Dark Mode preferences.
+description: |
+
+tags:


Suggested change

tags:

tags:

- post

post tag is required to show up on the blog landing page. I need to figure out a better way to make sure all blog posts get it automatically :\

robdodson · 2019-05-23T18:19:04Z

@@ -0,0 +1,174 @@
+---
+title: Hello Darkness, My Old Friend—Dark Theme is Here
+subhead:


Need a catchy subhead. This will appear on the post's card on the blog landing page and under the title on the article itself.

…ss/index.md Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>

- Add YouTube and native video examples to sandbox.

…v into prefers-color-scheme

netlify · 2019-06-18T12:26:35Z

Deploy preview for web-dev-staging ready!

Built with commit 8ad2cf5

https://deploy-preview-929--web-dev-staging.netlify.com

googlebot · 2019-06-18T12:27:21Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

tomayac · 2019-06-20T06:39:28Z

Sorry, I realized somehow this PR contains completely unrelated changes. Let me reopen.

tomayac · 2019-06-20T06:49:21Z

☝️ Started fresh in #1021.

mihajlija and others added 14 commits May 15, 2019 18:54

Add critical CSS codelab

b1628f5

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

027e37b

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

216e815

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

b62e008

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

8a769a9

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

add3f06

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

11c21c2

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

5358c15

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

22a93c6

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

bfabad9

…ss/index.md Co-Authored-By: Katie Hempenius <khempenius@users.noreply.github.com>

Format the options in the table

78ad3cb

Fix missing link

39207e6

Add a link to explain 14KB threshold

741b545

Migrate prefers-color-scheme article from WebFu

0aaa1a0

tomayac added the DO NOT MERGE Actively working on but experimental label May 23, 2019

tomayac mentioned this pull request May 23, 2019

Add prefers-color-scheme article google/WebFundamentals#7502

Closed

4 tasks

tomayac added the blog label May 23, 2019

robdodson and others added 3 commits May 23, 2019 10:16

Add gulp task so we can deploy styles. (#933)

6d88724

Make Houssein codeowner for React docs. (#934)

cc25619

robdodson requested review from Meggin and robdodson May 23, 2019 18:17

robdodson reviewed May 23, 2019

View reviewed changes

robdodson removed the request for review from Meggin May 23, 2019 18:19

addyosmani and others added 6 commits May 23, 2019 15:37

I/O 2019: Speed at Scale blog post recap (#931)

33790a3

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

f275c97

…ss/index.md Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

d4749aa

…ss/index.md Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

8e1fc2d

…ss/index.md Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

7d2f384

…ss/index.md Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>

Update src/site/content/en/fast/codelab-extract-and-inline-critical-c…

968add4

…ss/index.md Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>

robdodson and others added 10 commits June 14, 2019 14:35

Add YouTube shortcode. (#1006)

201ecec

- Add YouTube and native video examples to sandbox.

Remove extra lineitem div.

a0ae543

Add LightWallet article (#999)

f7964dd

Migrate prefers-color-scheme article from WebFu

8cf3fc0

Better align with web.dev template

c11f57e

Add glitch and network loading diagrams

dcfb2db

Write up how to use section

318cb72

Add iOS screenshot

3b64756

More stuff in the intro

3a28771

Merge branch 'prefers-color-scheme' of github.com:GoogleChrome/web.de…

27e1b8a

…v into prefers-color-scheme

googlebot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Jun 18, 2019

tomayac added 6 commits June 18, 2019 14:36

Remove new line

28e8b5a

Add more best practice

3ad3a01

Add opt-out <dark-mode-toggle> section

c23ccf7

First complete-ish draft

346155f

Some typo fixes

56f478e

Complete front matter

8ad2cf5

tomayac marked this pull request as ready for review June 19, 2019 14:55

tomayac requested review from Meggin and mfriesenhahn as code owners June 19, 2019 14:55

tomayac requested a review from robdodson June 19, 2019 14:55

tomayac closed this Jun 20, 2019

tomayac deleted the prefers-color-scheme branch June 20, 2019 06:39

tomayac changed the title ~~prefers-color-scheme article for web.dev~~ IGNORE prefers-color-scheme article for web.dev Jun 20, 2019

snyk-bot mentioned this pull request May 14, 2020

[Snyk] Upgrade lit-element from 2.2.0 to 2.3.1 christian7877/web.dev#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGNORE `prefers-color-scheme` article for web.dev#929

IGNORE `prefers-color-scheme` article for web.dev#929
tomayac wants to merge 107 commits into
masterfrom
prefers-color-scheme

tomayac commented May 23, 2019

Uh oh!

robdodson left a comment

Uh oh!

robdodson May 23, 2019

Uh oh!

robdodson May 23, 2019

Uh oh!

robdodson May 23, 2019

Uh oh!

netlify Bot commented Jun 18, 2019 •

edited

Loading

Uh oh!

googlebot commented Jun 18, 2019

Uh oh!

tomayac commented Jun 20, 2019

Uh oh!

tomayac commented Jun 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Conversation

tomayac commented May 23, 2019

Uh oh!

robdodson left a comment

Choose a reason for hiding this comment

Uh oh!

robdodson May 23, 2019

Choose a reason for hiding this comment

Uh oh!

robdodson May 23, 2019

Choose a reason for hiding this comment

Uh oh!

robdodson May 23, 2019

Choose a reason for hiding this comment

Uh oh!

netlify Bot commented Jun 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jun 18, 2019

Uh oh!

tomayac commented Jun 20, 2019

Uh oh!

tomayac commented Jun 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

netlify Bot commented Jun 18, 2019 •

edited

Loading