Switch wpt metric to be test_counts view by default#1240
Merged
jcscottiii merged 3 commits intomainfrom Mar 5, 2025
Merged
Conversation
This commit changes the default behavior for wpt_metric_view for:
- /v1/features
- /v1/features/{featureid}
This change will retrieve the WPT metrics as if view=test on wpt.fyi instead of the current behavior of view=subtest
On the frontend, allow the feature page (and chart panel) to configure which metric view to use by
reading the wpt_metric_view query parameter. We already do this on the overview page.
Add tests to assert the default behavior as well as behavior when explicitly setting the query parameter.
jrobbins
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the default behavior for wpt_metric_view for:
This change will retrieve the WPT metrics as if view=test on wpt.fyi instead of the current behavior of view=subtest
On the frontend, allow the feature page (and chart panel) to configure which metric view to use by reading the wpt_metric_view query parameter. We already do this on the overview page.
Add tests to assert the default behavior as well as behavior when explicitly setting the query parameter.
Other changes:
Fixes #1107