Add adapter logic that calls spanner to create user saved search#1245
Merged
jcscottiii merged 1 commit intomainfrom Mar 10, 2025
Merged
Add adapter logic that calls spanner to create user saved search#1245jcscottiii merged 1 commit intomainfrom
jcscottiii merged 1 commit intomainfrom
Conversation
This is the layer between the httpserver and spanner. It parses out the error if the user has too many saved searches.
jcscottiii
force-pushed
the
jcscottiii/adapter-create-user-saved-search
branch
from
d1c9944 to
1ec4682
Compare
KyleJu
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the layer between the httpserver and spanner.
It parses out the error if the user has too many saved searches.
After Spanner returns the ID, the adapter layer gets the full details from Spanner in a separate call. With the full details, it translates it into the SavedSearchResponse that is eventually returned.
Possible future changes