Add adapter logic that calls spanner to delete user saved search#1264
Merged
jcscottiii merged 1 commit intomainfrom Mar 11, 2025
Merged
Add adapter logic that calls spanner to delete user saved search#1264jcscottiii merged 1 commit intomainfrom
jcscottiii merged 1 commit intomainfrom
Conversation
This is the layer between the httpserver and spanner. It parses out the error if the: - The user does not have access, or - The entity does not exist Other changes - Modify the spanner logic to check if the entity exists in the same transaction
jrobbins
approved these changes
Mar 11, 2025
jcscottiii
added a commit
that referenced
this pull request
Mar 11, 2025
This change implements the http handler for removing a user saved search. After calling the adapter layer (which is implemented in #1264), we: - Check the error type to distinguish between: - A missing saved search - A saved search that the user does not have access to delete - A generic error
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
This change implements the http handler for removing a user saved search. After calling the adapter layer (which is implemented in #1264), we: - Check the error type to distinguish between: - A missing saved search - A saved search that the user does not have access to delete - A generic error
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the layer between the httpserver and spanner.
It parses out the error if the:
Other changes