Skip to content

Render users bookmarks in sidebar#1336

Merged
jcscottiii merged 1 commit intomainfrom
jcscottiii/ui-searches-v6.0.2
Mar 31, 2025
Merged

Render users bookmarks in sidebar#1336
jcscottiii merged 1 commit intomainfrom
jcscottiii/ui-searches-v6.0.2

Conversation

@jcscottiii
Copy link
Collaborator

@jcscottiii jcscottiii commented Mar 29, 2025

This change adds a new subsection to the sidebar that renders their bookmarks

Added a new playwright screenshot for authenticated users

If the user is not signed in or has no bookmarks, they will not see the section.

Other changes:

  • Moved login logic for playwright test to reusable helper

This is a split of #1330

Depends on #1335

image

@jcscottiii jcscottiii force-pushed the jcscottiii/ui-searches-v6.0.1 branch from eba3668 to 0f3160a Compare March 31, 2025 17:57
@jcscottiii jcscottiii force-pushed the jcscottiii/ui-searches-v6.0.2 branch from 2216a86 to 3a0863c Compare March 31, 2025 18:06
Base automatically changed from jcscottiii/ui-searches-v6.0.1 to main March 31, 2025 23:10
This change adds a new subsection to the sidebar that renders their bookmarks

Added a new playwright screenshot for authenticated users

If the user is not signed in or has no bookmarks, they will not see the section.

Other changes:
- Moved login logic for playwright test to reusable helper
@jcscottiii jcscottiii force-pushed the jcscottiii/ui-searches-v6.0.2 branch from 3a0863c to df564ae Compare March 31, 2025 23:10
@jcscottiii jcscottiii enabled auto-merge March 31, 2025 23:12
@jcscottiii jcscottiii added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit a4df6a1 Mar 31, 2025
6 checks passed
@jcscottiii jcscottiii deleted the jcscottiii/ui-searches-v6.0.2 branch March 31, 2025 23:51
@jrobbins jrobbins mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants