Skip to content

Combine mobile and desktop for "Global feature support" chart#1460

Merged
DanielRyanSmith merged 5 commits into
GoogleChrome:mainfrom
DanielRyanSmith:combine-feature-count
May 21, 2025
Merged

Combine mobile and desktop for "Global feature support" chart#1460
DanielRyanSmith merged 5 commits into
GoogleChrome:mainfrom
DanielRyanSmith:combine-feature-count

Conversation

@DanielRyanSmith
Copy link
Copy Markdown
Collaborator

This change updates the "Global feature support" chart to combine mobile and desktop feature counts for the 4 major browsers.

E.g. The chart now displays the count of unique features supported by both Firefox and Firefox for Android as the same line.

Comment thread lib/gcpspanner/browser_feature_count.go Outdated
Comment thread lib/gcpspanner/browser_feature_count_test.go Outdated
Comment thread lib/gcpspanner/browser_feature_count.go Outdated
@DanielRyanSmith DanielRyanSmith force-pushed the combine-feature-count branch 3 times, most recently from d4b21c8 to 8cef6f4 Compare May 19, 2025 16:29
Comment thread backend/pkg/httpserver/list_aggregated_feature_support.go Outdated
@DanielRyanSmith DanielRyanSmith force-pushed the combine-feature-count branch from 6c68191 to b07fb01 Compare May 20, 2025 18:57
Copy link
Copy Markdown
Collaborator

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts. But feel free to connect offline

Comment thread backend/pkg/httpserver/list_aggregated_feature_support.go Outdated
Comment thread lib/gcpspanner/browser_feature_count.go
Copy link
Copy Markdown
Collaborator

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions

Comment thread backend/pkg/httpserver/list_aggregated_feature_support.go
Comment thread backend/pkg/httpserver/list_aggregated_feature_support_test.go Outdated
Comment thread backend/pkg/httpserver/list_aggregated_feature_support_test.go Outdated
Comment thread backend/pkg/httpserver/list_aggregated_feature_support_test.go Outdated
Comment thread backend/pkg/httpserver/server_test.go Outdated
Comment thread backend/pkg/httpserver/server_test.go Outdated
@DanielRyanSmith DanielRyanSmith force-pushed the combine-feature-count branch from 3cbdb61 to c5fcda2 Compare May 21, 2025 22:11
@DanielRyanSmith DanielRyanSmith enabled auto-merge May 21, 2025 22:42
@DanielRyanSmith DanielRyanSmith added this pull request to the merge queue May 21, 2025
Merged via the queue into GoogleChrome:main with commit fd431a5 May 21, 2025
3 checks passed
@DanielRyanSmith DanielRyanSmith deleted the combine-feature-count branch May 21, 2025 23:06
@jstenback jstenback mentioned this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants