feat(spanner): Implement SyncUserProfileInfo with mappers#2009
Merged
jcscottiii merged 1 commit intomainfrom Nov 18, 2025
Merged
feat(spanner): Implement SyncUserProfileInfo with mappers#2009jcscottiii merged 1 commit intomainfrom
jcscottiii merged 1 commit intomainfrom
Conversation
jcscottiii
force-pushed
the
jcscottiii/sync-profile-backend
branch
from
3263054 to
88ab0fc
Compare
Implements the `SyncUserProfileInfo` functionality and related logic, fully leveraging the existing mapper pattern for atomic database operations. This new feature: - **Introduces New Files**: Adds `lib/gcpspanner/user_notification_channel.go` and `lib/gcpspanner/user_notification_channel_test.go` to manage user notification channels. - **Uses Transactional Helpers**: Leverages the `...WithTransaction` variants of the generic entity helpers (`newEntityCreator`, `newEntityWriter`) to ensure all database operations within `SyncUserProfileInfo` occur within a single, atomic transaction. This is a critical improvement for data integrity. For now, this implementation will re-activate a user's email channel if it was previously disabled on our side but is present in their verified GitHub emails. In the future, we may want to provide a manual way for users to re-enable channels themselves. This is captured in issue #2021.temp
jcscottiii
force-pushed
the
jcscottiii/sync-profile-backend
branch
from
88ab0fc to
a484fcc
Compare
jcscottiii
changed the title
jcscottiii
added a commit
that referenced
this pull request
Nov 18, 2025
…d mapper best practices This commit significantly updates the GEMINI.md knowledge base to reflect recent changes and codify best practices. Key updates include: - **Updated Last Analyzed Commit**: The SHA for the last analyzed commit has been updated to 4b12e1c. - **New Section: User Authentication and Notifications**: A new section (3.4) has been added to describe the architecture and data flow for user authentication, profile synchronization, notification channels, and saved search subscriptions. This includes correcting the API endpoint and handler names for user profile sync. - **Mapper Best Practices**: The "Go Mapper Pattern for Spanner" section (3.2.1) has been enhanced with new guidelines: - An explicit "DO" rule to ensure `mergeMapper` implementations correctly copy all fields, especially `UpdatedAt`. - A new subsection "Using Mappers within a Transaction" detailing the importance of using `...WithTransaction` variants of generic helpers within `ReadWriteTransaction` blocks and cautioning against standard helpers or manual mutation creation in such contexts. - **Architectural Layering**: A new "DON'T" rule has been added to prevent `lib/gcpspanner` from importing `lib/backendtypes`, reinforcing architectural separation. - **"Verify, Don't Assume" Principle**: A new core principle (5.9) has been introduced, emphasizing the importance of verifying information against canonical sources of truth (e.g., `openapi.yaml` for APIs, migration files for schema). This principle is also cross-referenced in the "Specifications & Generated Code" (Section 4) and "How-To Guides" (Section 6) sections, and explicitly integrated into the knowledge base update process (Section 7.2). These updates aim to improve the accuracy, clarity, and utility of the knowledge base for future development. I had GEMINI analyze #2009 and what existed on upstream main.
jrobbins
approved these changes
Nov 18, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
…d mapper best practices (#2022) * docs(gemini): Update knowledge base with user auth, notifications, and mapper best practices This commit significantly updates the GEMINI.md knowledge base to reflect recent changes and codify best practices. Key updates include: - **Updated Last Analyzed Commit**: The SHA for the last analyzed commit has been updated to 4b12e1c. - **New Section: User Authentication and Notifications**: A new section (3.4) has been added to describe the architecture and data flow for user authentication, profile synchronization, notification channels, and saved search subscriptions. This includes correcting the API endpoint and handler names for user profile sync. - **Mapper Best Practices**: The "Go Mapper Pattern for Spanner" section (3.2.1) has been enhanced with new guidelines: - An explicit "DO" rule to ensure `mergeMapper` implementations correctly copy all fields, especially `UpdatedAt`. - A new subsection "Using Mappers within a Transaction" detailing the importance of using `...WithTransaction` variants of generic helpers within `ReadWriteTransaction` blocks and cautioning against standard helpers or manual mutation creation in such contexts. - **Architectural Layering**: A new "DON'T" rule has been added to prevent `lib/gcpspanner` from importing `lib/backendtypes`, reinforcing architectural separation. - **"Verify, Don't Assume" Principle**: A new core principle (5.9) has been introduced, emphasizing the importance of verifying information against canonical sources of truth (e.g., `openapi.yaml` for APIs, migration files for schema). This principle is also cross-referenced in the "Specifications & Generated Code" (Section 4) and "How-To Guides" (Section 6) sections, and explicitly integrated into the knowledge base update process (Section 7.2). These updates aim to improve the accuracy, clarity, and utility of the knowledge base for future development. I had GEMINI analyze #2009 and what existed on upstream main. * Merge changes from #1960 * lint fix * more details * lint fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
SyncUserProfileInfofunctionality and related logic, fully leveraging the existing mapper pattern for atomic database operations. This new feature:lib/gcpspanner/user_notification_channel.goandlib/gcpspanner/user_notification_channel_test.goto manage user notification channels....WithTransactionvariants of the generic entity helpers (newEntityCreator,newEntityWriter) to ensure all database operations withinSyncUserProfileInfooccur within a single, atomic transaction. This is a critical improvement for data integrity.For now, this implementation will re-activate a user's email channel if it was previously disabled on our side but is present in their verified GitHub emails. In the future, we may want to provide a manual way for users to re-enable channels themselves. This is captured in issue #2021.