feat(email): Refactor documentation handling in email templates #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt5
branch
from
cd1eb5b to
fb75ef4
Compare
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt6
branch
from
f1c14b8 to
8ec7a43
Compare
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt5
branch
from
fb75ef4 to
f392e33
Compare
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt6
branch
from
8ec7a43 to
1c99fbc
Compare
This commit introduces a more structured approach to handling documentation links within the email templates. Previously, documentation links were represented by a `DocLinks []DocLink` slice, implicitly assuming all links were MDN. This limited the extensibility for future documentation sources. This change refactors the `DocLinks` field in `SummaryHighlight` to `Docs *Docs`, where `Docs` is a new struct containing `MDNDocs []DocLink`. This allows for explicit categorization of documentation types in the next PR. The `toDocLinks` function has been updated to construct and return the new `*Docs` struct.
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt6
branch
from
1c99fbc to
2ae9965
Compare
jrobbins
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a more structured approach to handling documentation links within the email templates.
Previously, documentation links were represented by a
DocLinks []DocLinkslice, implicitly assuming all links were MDN. This limited the extensibility for future documentation sources.This change refactors the
DocLinksfield inSummaryHighlighttoDocs *Docs, whereDocsis a new struct containingMDNDocs []DocLink. This allows for explicit categorization of documentation types in the next PR.The
toDocLinksfunction has been updated to construct and return the new*Docsstruct.