Conversation
neilv-g
commented
Apr 6, 2026
neilv-g
force-pushed
the
neilv-rss-2
branch
2 times, most recently
from
d22c661 to
61d9fe9
Compare
jcscottiii
reviewed
Apr 7, 2026
jcscottiii
approved these changes
Apr 7, 2026
Collaborator
jcscottiii
left a comment
jcscottiii
left a comment
There was a problem hiding this comment.
LGTM with use of getPageSizeOrDefault
This is a first go at implementing this API and is *not* the final form of it. A few things that still need to be done: - With this change, JSON is just being inserted into the XML. This will need to be more properly formatted. - Caching of the responses from the RSS API. - Hardcoding the # of events/diffs returned to the API to 20 for now. Open to any number on this.
neilv-g
force-pushed
the
neilv-rss-2
branch
3 times, most recently
from
eb1fde4 to
4617729
Compare
- Adjusts SQL cursor sequencing to sort `EventId ASC`. This seamlessly harmonizes with Spanner's default ASC primary key appending so the query plans can completely pipeline native index traversals correctly on identical log timestamps. - Refines `<guid>` serialization to export `isPermaLink="false"`, guarding UUID structures from triggering automatic link parses across rigorous external RSS aggregators. - Inserts standard self-reference atomic path mappings (`rel="self"`) to fortify document compliance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first go at implementing this API and is not the final form of it. A few things that still need to be done: