Skip to content

feat(db): add system global searches support#2419

Merged
jcscottiii merged 2 commits intomainfrom
feat/saved-search-db-system
Apr 21, 2026
Merged

feat(db): add system global searches support#2419
jcscottiii merged 2 commits intomainfrom
feat/saved-search-db-system

Conversation

@jcscottiii
Copy link
Copy Markdown
Collaborator

@jcscottiii jcscottiii commented Apr 13, 2026

Title: feat(db): add system global searches support

Description

This PR introduces database support and data seeding for System Global Saved Searches. These are curated searches (such as Baseline years and Top Interop issues) that are visible to all users and managed by the system.

Key Changes

  • Schema: Added SystemGlobalSavedSearches and SavedSearchFeatureSortOrder tables in Spanner (Migration 000031).
  • Data: Seeded initial data for Baseline (2020-2026) and Top CSS/HTML Interop issues (Migration 000032).
  • Go Backend:
    • Added SystemGlobalScope to SavedSearchScope.
    • Implemented ListSystemGlobalSavedSearches and GetSystemGlobalSavedSearch using the project's Mapper pattern.
    • Added GetReferencingSavedSearchIDs to find searches that embed a specific search ID.
  • Tests: Added integration tests to verify listing and retrieval of global searches.

@jcscottiii jcscottiii force-pushed the feat/saved-search-grammar branch from f3801cf to e4b8703 Compare April 15, 2026 18:44
@jcscottiii jcscottiii force-pushed the feat/saved-search-db-system branch 2 times, most recently from 4fe8e5a to d190a29 Compare April 15, 2026 20:18
@jcscottiii jcscottiii requested review from jrobbins and neilv-g April 16, 2026 16:27
Comment thread infra/storage/spanner/migrations/000031.sql
Comment thread infra/storage/spanner/migrations/000031.sql
Comment thread lib/gcpspanner/saved_searches_test.go Outdated
Base automatically changed from feat/saved-search-grammar to main April 20, 2026 21:28
@jcscottiii jcscottiii force-pushed the feat/saved-search-db-system branch from d190a29 to 8dc3487 Compare April 21, 2026 13:46
@jcscottiii jcscottiii force-pushed the feat/saved-search-db-system branch from 8dc3487 to cf1faab Compare April 21, 2026 14:08
@jcscottiii jcscottiii added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit fe2506a Apr 21, 2026
9 of 10 checks passed
@jcscottiii jcscottiii deleted the feat/saved-search-db-system branch April 21, 2026 15:58
@szy196 szy196 mentioned this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants