Add plumbing between spanner & http for missing one implementation#904
Merged
jcscottiii merged 1 commit intomainfrom Nov 14, 2024
Merged
Add plumbing between spanner & http for missing one implementation#904jcscottiii merged 1 commit intomainfrom
jcscottiii merged 1 commit intomainfrom
Conversation
Fixes #880 This change adds the spanner adapter conversion layer. This converts the data from spanner to the expected missing one implementation page that is documented in the openapi yaml for the endpoint. This change has the http layer call this layer for the endpoint. Heavily inspired by: - [backend/pkg/httpserver/list_aggregated_feature_support.go](https://github.com/GoogleChrome/webstatus.dev/blob/main/backend/pkg/httpserver/list_aggregated_feature_support.go) - The [ListBrowserFeatureCountMetric method in lib/gcpspanner/spanneradapters/backend.go](https://github.com/GoogleChrome/webstatus.dev/blob/40b461b550bbb32b432a6dd219e9ccf94b249d23/lib/gcpspanner/spanneradapters/backend.go#L99-L133) Other changes: - Fix log statement in backend/pkg/httpserver/list_aggregated_feature_support.go
jrobbins
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #880
This change adds the spanner adapter conversion layer for the missing one implementation endpoint. This converts the data from spanner to the expected missing one implementation page that is documented in the openapi yaml for the endpoint.
This change has the http layer call this layer for the endpoint.
Heavily inspired by:
Other changes: