Make sw-cli public#240
Merged
Merged
Conversation
jeffposnick
approved these changes
Feb 23, 2017
addyosmani
reviewed
Feb 28, 2017
| { | ||
| "name": "sw-cli", | ||
| "version": "0.0.8", | ||
| "private": true, |
Contributor
There was a problem hiding this comment.
👍 Noticed this is also in https://www.npmjs.com/package/sw-cli and we've been keeping the package updated. We might want to chat sometime about whether we version up all of the packages in the repo at the same time (e.g like Angular does) or keep them individual.
Author
There was a problem hiding this comment.
Lerna will make them all publish with same version if they change and when they do - they jump to the latest version number. I think this has been good so far and makes sense to avoid needless churn for updates for projects depending on us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @addyosmani
I can haz?