Fixes unhandled rejections in Windows tests#2452
Merged
philipwalton merged 1 commit intomasterfrom Apr 13, 2020
Merged
Conversation
Contributor
Author
|
That test looks good now: https://github.com/GoogleChrome/workbox/pull/2452/checks?check_run_id=583544083#step:6:60 |
philipwalton
approved these changes
Apr 13, 2020
This was referenced Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
I noticed while looking at our CI output that there are some test cases in the Windows suite that should have been failed, but passed because of a missing
await:https://github.com/GoogleChrome/workbox/pull/2451/checks?check_run_id=583425178#step:6:60
This PR adds that
awaitto ensure that an exception in theasyncsub-function properly fails our main test case. It also fixes the logic so that the Windows tests should pass.(They were failing because a Windows path separator isn't meant to be used in a
globbypattern.)