Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

Conversation

@navierula
Copy link
Contributor

No description provided.

@navierula navierula requested a review from davidstanke January 31, 2020 23:09
@navierula navierula changed the title add maven code sample add maven and gradle code samples Jan 31, 2020
@navierula navierula changed the title add maven and gradle code samples add gradle code samples Feb 1, 2020
@navierula navierula changed the title add gradle code samples add maven and gradle code samples Feb 1, 2020
Copy link

@davidstanke davidstanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! I have just one suggestion, which I recommend you do in a separate PR after merging this one...

We can make it so users can do the Maven build locally, without having to install Maven to their system:

  1. in the "maven-example" directory, run mvn -N io.takari:maven:wrapper
  2. this will create a .mvn directory; git add and commit this
  3. now, when people clone the repo, they can run Maven commands locally with ./mvnw <command> (without needing to have maven on their system)

I ran the builds locally and in Cloud Build and everything worked. :)

@navierula
Copy link
Contributor Author

@davidstanke, thanks for your review and for running these builds. After merging this PR, I'll follow those steps. @loosebazooka, I'm curious if something similar can be done for gradle?

A general question - should I mention in the README for these repos that start.spring.io was used to generate them?

@davidstanke
Copy link

davidstanke commented Feb 5, 2020 via email

@loosebazooka
Copy link

Oh sorry I missed this. Look good to me.

@navierula navierula merged commit 6632431 into GoogleCloudBuild:master Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants