Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Move tempLocation to PipelineOptions.#194

Merged
davorbonaci merged 1 commit intoGoogleCloudPlatform:masterfrom
peihe:master
Apr 9, 2016
Merged

Move tempLocation to PipelineOptions.#194
davorbonaci merged 1 commit intoGoogleCloudPlatform:masterfrom
peihe:master

Conversation

@peihe
Copy link
Contributor

@peihe peihe commented Apr 8, 2016

It is back ported from:
apache/beam#44

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@peihe
Copy link
Contributor Author

peihe commented Apr 8, 2016

R: @dhalperi

@dhalperi
Copy link
Contributor

dhalperi commented Apr 8, 2016

R: @davorbonaci

Davor explicitly decided not to backport this in the Great Backporting of 2016 (tm) because it is not backwards-compatible.

@davorbonaci
Copy link
Contributor

It is backward-compatible. Merging.

@davorbonaci davorbonaci merged commit 8077986 into GoogleCloudPlatform:master Apr 9, 2016
dhalperi pushed a commit that referenced this pull request Apr 14, 2016
Move tempLocation to PipelineOptions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants