This repository was archived by the owner on Nov 11, 2022. It is now read-only.
BigQueryTableInserter: fix issues in insertAll and add better tests #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM |
Contributor
|
LGTM |
Contributor
Author
|
The travis test has fully passed in my branch: https://travis-ci.org/dhalperi/DataflowJavaSDK/builds/163244980 The travis run for this branch has not started despite waiting 2 hours. I'm not sure what to do, but given that it is okay to go ahead and merge this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of apache/beam#1018
Please scrutinize because the rebase did not apply at all -- the code is in different files entirely.