This repository was archived by the owner on Nov 11, 2022. It is now read-only.
BoundedReadFromUnboundedSourceTest: fixes#452
Merged
lukecwik merged 1 commit intoGoogleCloudPlatform:masterfrom Sep 29, 2016
dhalperi:timeBoundedTest
Merged
BoundedReadFromUnboundedSourceTest: fixes#452lukecwik merged 1 commit intoGoogleCloudPlatform:masterfrom dhalperi:timeBoundedTest
lukecwik merged 1 commit intoGoogleCloudPlatform:masterfrom
dhalperi:timeBoundedTest
Conversation
1) Tests actually require non-splitting source (assert that the Key is 0). Use withoutSplitting. 2) Indentation and unused code (expectedOutput). 3) For these time-based tests, runners cannot guarantee we'll produce at least 3 elements, but we can expect there to be at least 1. These appear in Beam but were not backported: apache/beam@fecd036 apache/beam@ee7272f
Contributor
|
LGTM |
Contributor
|
Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests actually require non-splitting source (assert that the Key is 0).
Use withoutSplitting.
Indentation and unused code (expectedOutput).
For these time-based tests, runners cannot guarantee we'll produce
at least 3 elements, but we can expect there to be at least 1.
These appear in Beam but were not backported:
apache/beam@fecd036
apache/beam@ee7272f