Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Add saveProfilesToGcs option; deprecate enableProfilingAgent #497

Merged
merged 7 commits into from
Dec 12, 2016
Merged

Add saveProfilesToGcs option; deprecate enableProfilingAgent #497

merged 7 commits into from
Dec 12, 2016

Conversation

@bjchambers
Copy link
Contributor

@bjchambers bjchambers commented Dec 8, 2016

No description provided.

@davorbonaci
Copy link
Contributor

davorbonaci commented Dec 8, 2016

Is this a backport?

davorbonaci
davorbonaci reviewed Dec 8, 2016
View reviewed changes
sdk/src/main/java/com/google/cloud/dataflow/sdk/runners/DataflowPipelineRunner.java Outdated
}
if (dataflowOptions.getEnableProfilingAgent()) {
LOG.error("--enableProfilingAgent is no longer supported, and will be ignored. "
+ "Use --saveProfilesToGcs instead");
Copy link
Contributor

@davorbonaci davorbonaci Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'.' at the end of the sentence ;-)

Copy link
Contributor Author

@bjchambers bjchambers Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bjchambers
Copy link
Contributor Author

bjchambers commented Dec 8, 2016

Not really backport or forward port. Just wrote both PRs. See apache/beam#1554.

@bjchambers
Copy link
Contributor Author

bjchambers commented Dec 8, 2016

Travis failures seem spurious -- WordCount class is missing. I'll squash and force push to kick off new run.

@bjchambers
Copy link
Contributor Author

bjchambers commented Dec 9, 2016

This is back to failing with:

[WARNING] 
java.lang.ClassNotFoundException: com.google.cloud.dataflow.examples.WordCount
	at java.net.URLClassLoader$1.run(URLClassLoader.java:372)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:281)

@bjchambers bjchambers merged commit 8a7f299 into GoogleCloudPlatform:master Dec 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@davorbonaci davorbonaci davorbonaci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjchambers @davorbonaci @googlebot