Skip to content

Increasing maxConnection on MySqlResourceManager For AllDataTypesIT#3147

Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle:it-max-connections
Dec 23, 2025
Merged

Increasing maxConnection on MySqlResourceManager For AllDataTypesIT#3147
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle:it-max-connections

Conversation

@VardhanThigle
Copy link
Contributor

@VardhanThigle VardhanThigle commented Dec 23, 2025

IT only Change - Increasing maxConnection on Containarized MySqlResourceManager For AllDataTypesIT, this is to unblock #3046 which is adding more schema elements to AllDataTypesIT for cross Schema Testing thereby opening more connection to the container (active connections = O(tables)).

TODO: Waiting for IT run to check if this works.

@gemini-code-assist
Copy link

Summary of Changes

Hello @VardhanThigle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a configuration adjustment for the MySQL database used in the AllDataTypesIT integration tests. By increasing the max_connections global variable, the change aims to prevent potential connection exhaustion issues that might arise during the execution of these tests, thereby enhancing their stability and reliability.

Highlights

  • MySQL Configuration: Increased the max_connections global variable to 300 within the mysql-data-types.sql script. This adjustment is specifically targeted at the AllDataTypesIT integration tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@VardhanThigle VardhanThigle added the integration testing Migration of integration tests to github label Dec 23, 2025
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.12%. Comparing base (4f0f93d) to head (a9690cc).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3147      +/-   ##
============================================
+ Coverage     50.71%   56.12%   +5.41%     
+ Complexity     5084     1693    -3391     
============================================
  Files           974      471     -503     
  Lines         59904    26662   -33242     
  Branches       6543     2805    -3738     
============================================
- Hits          30379    14965   -15414     
+ Misses        27380    10800   -16580     
+ Partials       2145      897    -1248     
Components Coverage Δ
spanner-templates 72.14% <100.00%> (+1.28%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 80.04% <ø> (ø)
spanner-live-reverse-replication 77.73% <ø> (ø)
spanner-bulk-migration 88.46% <100.00%> (+0.08%) ⬆️
see 522 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VardhanThigle VardhanThigle marked this pull request as ready for review December 23, 2025 10:02
@VardhanThigle VardhanThigle requested a review from a team as a code owner December 23, 2025 10:02
@VardhanThigle VardhanThigle changed the title [Draft - Testing] Increasing maxConnection on MySqlResourceManager For AllDataTypesIT Increasing maxConnection on MySqlResourceManager For AllDataTypesIT Dec 23, 2025
@VardhanThigle VardhanThigle merged commit a16c225 into GoogleCloudPlatform:main Dec 23, 2025
20 checks passed
MnkyGns pushed a commit to MnkyGns/DataflowTemplates that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release integration testing Migration of integration tests to github size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants