Skip to content

Conversation

@bharadwaj-aditya
Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya commented Jan 8, 2026

This log was added to call out scenarios where the previous event and current event have exactly the same log file, position and timestamp indicating some issue with the source data. There is no action item, but the idea was that it is something to watch out for is it happens often enough.

However there are a couple of scenarios where this may come up in the regular flows

  1. In the multi db flow (with distributed transactions) - In the second check to ensure the row has not changed outside transaction, this will be logged for every event
  2. In the single DB flow (without distributed transactions) If an event is retried due to write to

This logging in the regular flows is leading to throttling, hence removing this logger.

@gemini-code-assist
Copy link

Summary of Changes

Hello @bharadwaj-aditya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the ChangeEventSequence comparison logic by eliminating a redundant warning log. The removed log message was generated when comparing events that shared the same log file, position, and timestamp, which is no longer considered a scenario requiring a warning.

Highlights

  • Logging Cleanup: Removed a specific LOG.warn message from the compareTo method in MySqlChangeEventSequence.java. This warning was previously triggered when two ChangeEventSequence objects had identical log file, position, and timestamp during comparison.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.86%. Comparing base (b592ea1) to head (ab9acec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3203      +/-   ##
============================================
+ Coverage     50.86%   54.86%   +4.00%     
+ Complexity     5132     2249    -2883     
============================================
  Files           976      490     -486     
  Lines         60093    28463   -31630     
  Branches       6573     2997    -3576     
============================================
- Hits          30565    15617   -14948     
+ Misses        27375    11890   -15485     
+ Partials       2153      956    -1197     
Components Coverage Δ
spanner-templates 72.17% <100.00%> (+1.15%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 80.12% <100.00%> (+0.02%) ⬆️
spanner-live-reverse-replication 77.72% <ø> (-0.05%) ⬇️
spanner-bulk-migration 88.44% <ø> (ø)
Files with missing lines Coverage Δ
...templates/datastream/MySqlChangeEventSequence.java 87.50% <100.00%> (+2.42%) ⬆️

... and 503 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bharadwaj-aditya bharadwaj-aditya merged commit 7be9f75 into GoogleCloudPlatform:main Jan 8, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants