Skip to content

update activemq to minimize vulnerabilities#3637

Draft
derrickaw wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260406_activemqUpdate
Draft

update activemq to minimize vulnerabilities#3637
derrickaw wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260406_activemqUpdate

Conversation

@derrickaw
Copy link
Copy Markdown
Contributor

@derrickaw derrickaw commented Apr 7, 2026

  1. Update activemq to 5.19.x to minimize vulnerabilities.
  2. Will leave a further upgrade to 6.2.x for after Beam 2.73 is released.
  3. Gets half way to the end result of this build(deps): bump org.apache.activemq:activemq-client from 5.17.7 to 6.2.3 #3594

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the ActiveMQ dependency to a newer version to mitigate known security vulnerabilities. The change includes updated documentation within the configuration file to reflect the current messaging API compatibility status and outlines the necessary steps for future upgrades.

Highlights

  • Dependency Update: Updated the ActiveMQ version from 5.17.7 to 5.19.3 in the project pom.xml to address security vulnerabilities.
  • Documentation Update: Updated comments in the pom.xml to clarify the current JMS compatibility constraints and future migration requirements for Apache Beam.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.30%. Comparing base (53e3d7e) to head (d1763c8).

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3637       +/-   ##
=============================================
+ Coverage     37.64%   52.30%   +14.65%     
- Complexity      614     6145     +5531     
=============================================
  Files           207     1054      +847     
  Lines         14226    63563    +49337     
  Branches       1451     6979     +5528     
=============================================
+ Hits           5355    33244    +27889     
- Misses         8400    28064    +19664     
- Partials        471     2255     +1784     
Components Coverage Δ
spanner-templates 72.14% <ø> (∅)
spanner-import-export 68.88% <ø> (∅)
spanner-live-forward-migration 80.36% <ø> (∅)
spanner-live-reverse-replication 77.82% <ø> (∅)
spanner-bulk-migration 89.18% <ø> (∅)
gcs-spanner-dv 85.32% <ø> (∅)
see 866 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw added the improvement Making existing code better label Apr 7, 2026
@derrickaw derrickaw marked this pull request as ready for review April 7, 2026 12:17
@derrickaw derrickaw requested a review from Abacn April 7, 2026 12:18
@derrickaw
Copy link
Copy Markdown
Contributor Author

Hi @Abacn, I am guessing that this upgrade is causing the Java PR tests to run beyond the 4 hour limit which seems like a regression of ~73 minutes to 240 minutes to be not a good move for us at this time. I am going to postpone this PR or even close it and redo it for 6.2.x once Beam 2.73 comes in. Sound good? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants