This repository was archived by the owner on Jan 23, 2024. It is now read-only.
Add support to build release candidates#39
Merged
mctavish merged 17 commits intoGoogleCloudPlatform:mainfrom Jun 13, 2022
Merged
Add support to build release candidates#39mctavish merged 17 commits intoGoogleCloudPlatform:mainfrom
mctavish merged 17 commits intoGoogleCloudPlatform:mainfrom
Conversation
jasonborg
approved these changes
Jun 8, 2022
Contributor
jasonborg
left a comment
jasonborg
left a comment
There was a problem hiding this comment.
It all looks good/reasonable
It requires the python regression test suite, which is not present in python3 distributions
Contributor
Author
|
Added tests! PTAL |
jasonborg
approved these changes
Jun 10, 2022
Contributor
jasonborg
left a comment
jasonborg
left a comment
There was a problem hiding this comment.
Everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository has previously been a mirror of a Google-internal one, and releases have been built from the internal repository.
This PR adds support to build release candidates directly from this repository than can be tested and uploaded to pypi.
Many unit tests have been added, but some are disabled until they can successfully pass on all supported versions of Python.
One change has been lumped into this: SetConditionalBreakpoint has been split into CreateConditionalBreakpoint and ActivateConditionalBreakpoint. This change fixes an edge cases where a breakpoint could be created and not deleted if there is a failure at the wrong time. This issue was discovered during testing.