feat: update variableValue yaml tag to be plural#2777
feat: update variableValue yaml tag to be plural#2777vicentefb wants to merge 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
apeabody
left a comment
There was a problem hiding this comment.
Hi @vicentefb
Should this change also trigger a release? https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/main/cli/Makefile#L4
d55442a to
23cf365
Compare
|
Yes @apeabody done, thanks! |
Thanks @vicentefb - I'll defer to @g-awmalik for final approval as this appears to be a potentially breaking change. |
|
I might need to hold this until an update is made to a query as well as the removal of an old field which is not reflected here. |
Hi @vicentefb - Please remove the |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
variableValueyaml tag insideDisplayVariableTogglefield needs to be updated to bevariableValuesto be consistent.