Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Revert 'Update all release time rows in a single batch'#226

Merged
brianquinlan merged 55 commits into
GoogleCloudPlatform:masterfrom
brianquinlan:master
Jan 23, 2019
Merged

Revert 'Update all release time rows in a single batch'#226
brianquinlan merged 55 commits into
GoogleCloudPlatform:masterfrom
brianquinlan:master

Conversation

@brianquinlan
Copy link
Copy Markdown
Contributor

No description provided.

@liyanhui1228
Copy link
Copy Markdown
Member

Is this reverting a previous commit? Also it would be nice to rebase the branch so that it won't show those previous commits not included in this PR.

@brianquinlan
Copy link
Copy Markdown
Contributor Author

Yes, this is reverting a previous commit. Can I rebase when I've already created the PR?

@liyanhui1228
Copy link
Copy Markdown
Member

Probably try:

$ git fetch upstream
$ git rebase -i upstream/master
$ # In the rebase UI, pick the top one commit and mark all others as "squash" or "s". Save and exit.
$ # Resolve any potential merge conflicts.
$ # Should see: Successfully rebased and updated refs/heads/master.
$ git push -f origin

@liyanhui1228
Copy link
Copy Markdown
Member

And the changes LGTM.

@brianquinlan
Copy link
Copy Markdown
Contributor Author

Let me submit and then I'll try the rebase when we don't have a broken repo.

@brianquinlan brianquinlan merged commit d88bb53 into GoogleCloudPlatform:master Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants