This repository was archived by the owner on Oct 21, 2022. It is now read-only.
A few clean-ups#261
Merged
liyanhui1228 merged 4 commits intoGoogleCloudPlatform:masterfrom Feb 25, 2019
Merged
Conversation
ylil93
suggested changes
Feb 25, 2019
| mysql_user=None, | ||
| mysql_password=None, | ||
| mysql_host=None, | ||
| mysql_port=None, |
Contributor
There was a problem hiding this comment.
Nice - I was going to do a PR for this as well!
Is there a reason the default value is set to None rather than 3306?
It seems redundant to have this appear later on:
if mysql_port is None:
mysql_port = 3306
ylil93
approved these changes
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.