This repository was archived by the owner on Oct 21, 2022. It is now read-only.
update package and whitelists with new google python packages#327
Merged
ylil93 merged 2 commits intoGoogleCloudPlatform:masterfrom Jun 5, 2019
Merged
update package and whitelists with new google python packages#327ylil93 merged 2 commits intoGoogleCloudPlatform:masterfrom
ylil93 merged 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
liyanhui1228
reviewed
Jun 5, 2019
| 'google-cloud-automl', | ||
| 'google-cloud-bigquery', | ||
| 'google-cloud-bigquery-datatransfer', | ||
| 'google-cloud-bigquery-storage', |
Member
There was a problem hiding this comment.
Are those packages newly released to PyPI?
Contributor
Author
There was a problem hiding this comment.
I commented out the ones that haven't been released yet, but seems like update_dashboard tests are failing, so it might be that I missed some? I will check it out.
Member
There was a problem hiding this comment.
Yeah it happened before when a new package exists in the google-cloud-python github repo but hasn't been released to PyPI yet, which will cause our server to fail.
And per offline discussion, skip the tests until the data for newly added packaged populated in Cloud SQL makes sense.
liyanhui1228
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.