Clean third_party/googleapis submodules.#2
Clean third_party/googleapis submodules.#2aalexand merged 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
Remove submodules from git index with "git rm".
| $ git subtree add --prefix third_party/googleapis googleapis master --squash | ||
| $ rm third_party/googleapis/.gitmodules | ||
| $ # For all submodules: | ||
| $ git rm third_party/googleapis/{path_to_submodule} |
There was a problem hiding this comment.
Could this use "git submodule foreach"?
There was a problem hiding this comment.
"git submodule foreach" returns fatal: No url found for submodule path 'third_party/googleapis/third_party/boringssl-with-bazel' in .gitmodules (with third_party/googleapis/.gitmodules undeleted). Not sure how to make use of .gitmodules in a subtree. Also sounds like 'git submodule foreach' will skip uninitialized module. We probably don't want to initialize them?
There was a problem hiding this comment.
I am just not sure what "For all submodules" means here. Is this command something that needs to be run every time the subtree needs to be updated? If so, the instructions on what "all" means here should be clearer (ideally just some command that gathers that). If this text is about the one time subtree addition that was done, then perhaps list explicit submodules you removed?
There was a problem hiding this comment.
It's a one time setup. It's sufficient to follow "To update from remote on an ongoing basis" instructions below to update the subtree.
Sure, updated the PR to list explicit submodules removed.
2 participants
Remove submodules from git index with "git rm".