Skip to content

Conversation

@enocom
Copy link
Member

@enocom enocom commented Nov 30, 2022

Fixes #67.

@enocom enocom requested a review from a team November 30, 2022 20:20
@enocom
Copy link
Member Author

enocom commented Nov 30, 2022

This will need to update the proxy version to v2.0.0-preview.4 to work.

Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hessjcg
Copy link
Collaborator

hessjcg commented Dec 12, 2022

Issue #144 contains additional work to clean up the way git sha and version are embedded.

Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enocom
Copy link
Member Author

enocom commented Dec 12, 2022

We're going to avoid the parameter usage in a future commit. See #144.

@enocom enocom dismissed kurtisvg’s stale review December 12, 2022 19:56

Pulled work to use go:embed into #144.

@hessjcg hessjcg merged commit 803446d into main Dec 12, 2022
@hessjcg hessjcg deleted the user-agent branch December 12, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cloudsql-proxy user agent env variable for tracking

3 participants