fix: Case issue with pod State (#386)#387
Merged
enocom merged 1 commit intoGoogleCloudPlatform:mainfrom Jul 6, 2023
CoryHagerman:fix-386
Merged
fix: Case issue with pod State (#386)#387enocom merged 1 commit intoGoogleCloudPlatform:mainfrom CoryHagerman:fix-386
enocom merged 1 commit intoGoogleCloudPlatform:mainfrom
CoryHagerman:fix-386
Conversation
The case of "off" in "CrashLoopBackoff" needs to be capitalized in order for the comparison check to match in podspec_updates.go
Member
|
@hessjcg Will you take a look and merge this assuming we're good? |
hessjcg
approved these changes
Jul 6, 2023
Collaborator
hessjcg
left a comment
hessjcg
left a comment
There was a problem hiding this comment.
Good catch. Thank you for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case of "off" in "CrashLoopBackoff" needs to be capitalized in order for the comparison check to match in podspec_updates.go
Fixes #386