Proxy rejects requests for first generation instances. #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First generation instances are not supported by the proxy, so this causes them to fail slightly faster.
Carrotman42
reviewed
Apr 4, 2019
Contributor
Carrotman42
left a comment
Carrotman42
left a comment
There was a problem hiding this comment.
Generally you should return errors or log them, not both.
Contributor
Author
|
The log and error have slightly different content... @Carrotman42 are you OK with that? Or would you rather I remove the logs altogether? |
Carrotman42
approved these changes
Apr 5, 2019
Contributor
Carrotman42
left a comment
Carrotman42
left a comment
There was a problem hiding this comment.
I guess it doesn't matter too much, people shouldn't try to do v1 connections anyway.
Sorry for the delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First generation instances are not supported by the proxy, so this causes connections to them to fail slightly faster (otherwise we need to wait for the connection to timeout!)