Skip to content

chore: fix failing type checks #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

chore: fix failing type checks #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import Iterable
from typing import List

try:
import pkg_resources
Expand All @@ -21,4 +21,4 @@
except ImportError:
import pkgutil

__path__: Iterable[str] = pkgutil.extend_path(__path__, __name__)
__path__: List[str] = pkgutil.extend_path(__path__, __name__)
4 changes: 2 additions & 2 deletions google/cloud/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from typing import Iterable
from typing import List

try:
import pkg_resources
Expand All @@ -20,4 +20,4 @@
except ImportError:
import pkgutil

__path__: Iterable[str] = pkgutil.extend_path(__path__, __name__)
__path__: List[str] = pkgutil.extend_path(__path__, __name__)
4 changes: 2 additions & 2 deletions google/cloud/sql/connector/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
"""

from typing import Iterable
from typing import List

from .connector import connect
from .instance_connection_manager import CloudSQLConnectionError, IPTypes
Expand All @@ -29,4 +29,4 @@
except ImportError:
import pkgutil

__path__: Iterable[str] = pkgutil.extend_path(__path__, __name__)
__path__: List[str] = pkgutil.extend_path(__path__, __name__)
3 changes: 2 additions & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ def lint(session):
serious code quality issues.
"""
session.install(
"flake8", "flake8-annotations", "black", "mypy", "sqlalchemy-stubs", "twine")
"flake8", "flake8-annotations", "black", "mypy", "sqlalchemy-stubs",
"types-pkg-resources", "types-PyMySQL", "twine")
session.install("-r", "requirements.txt")
session.run("black", "--check", *BLACK_PATHS)
session.run("flake8", "google", "tests")
Expand Down