Skip to content

feat: expose Connector object to allow multiple connection configurations. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 10, 2021
Merged

feat: expose Connector object to allow multiple connection configurations. #210

merged 13 commits into from
Dec 10, 2021

Conversation

@jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Dec 9, 2021

No description provided.

@jackwotherspoon jackwotherspoon linked an issue Dec 9, 2021 that may be closed by this pull request
Expose connector object for multiple conflicting configurations, #185
Closed
kurtisvg
kurtisvg suggested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests that we should update to use a Connector object. That can be done in a separate PR w/ mocking if you want, just want to make sure it's on your radar.

jackwotherspoon
jackwotherspoon commented Dec 9, 2021
View reviewed changes
@jackwotherspoon jackwotherspoon merged commit cef1ed1 into main Dec 10, 2021
@jackwotherspoon jackwotherspoon deleted the expose-connector branch December 10, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose connector object for multiple conflicting configurations,

3 participants

@jackwotherspoon @kurtisvg