Skip to content

Add integration test for HTCondor #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tpdownes merged 2 commits into from
Jun 22, 2022
Merged

Add integration test for HTCondor #362

tpdownes merged 2 commits into from
Jun 22, 2022

Conversation

@tpdownes
Copy link
Contributor

@tpdownes tpdownes commented Jun 3, 2022

This PR is dependent upon #361

  • create and delete image
  • provision and destroy pool using image
  • confirm that Access Point has joined the pool by querying the Central Manager from the Access Point

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes requested a review from nick-stroud June 3, 2022 20:53
@tpdownes tpdownes assigned nick-stroud and unassigned nick-stroud Jun 3, 2022
@tpdownes tpdownes removed the request for review from nick-stroud June 9, 2022 23:25
@tpdownes tpdownes marked this pull request as draft June 9, 2022 23:25
@tpdownes
Add integration test for HTCondor
ad8d8bc 
- HTCondor example remains experimental
- create and delete image
- provision and destroy pool
@tpdownes tpdownes force-pushed the feat_htcondor_integration_test branch from 43c3957 to ad8d8bc Compare June 10, 2022 15:59
@tpdownes tpdownes marked this pull request as ready for review June 10, 2022 18:04
@tpdownes tpdownes requested a review from cboneti June 13, 2022 19:47
@tpdownes tpdownes mentioned this pull request Jun 13, 2022
Merged
6 tasks
cboneti
cboneti reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One minor comment.
While you are at it, could you please update the comments at integration-group-3.yaml as well? if has become of sync.

@cboneti cboneti assigned tpdownes and unassigned cboneti Jun 22, 2022
@tpdownes tpdownes assigned cboneti and unassigned tpdownes Jun 22, 2022
@tpdownes tpdownes merged commit 3b487b9 into GoogleCloudPlatform:develop Jun 22, 2022
@cboneti cboneti assigned tpdownes and unassigned cboneti Jun 22, 2022
@tpdownes tpdownes deleted the feat_htcondor_integration_test branch June 22, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cboneti cboneti cboneti approved these changes

Assignees

@tpdownes tpdownes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tpdownes @cboneti @nick-stroud