-
Notifications
You must be signed in to change notification settings - Fork 269
Maintenance of VPC module #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tpdownes
merged 4 commits into
GoogleCloudPlatform:develop
from
tpdownes:feat_vpc_updates
Jul 7, 2022
Merged
Maintenance of VPC module #386
tpdownes
merged 4 commits into
GoogleCloudPlatform:develop
from
tpdownes:feat_vpc_updates
Jul 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-stroud
previously approved these changes
Jul 7, 2022
ce07bda to
c7ee467
Compare
Contributor
Author
|
One of your comments prompted a real change to keep the distinct |
* add input variable to supply custom firewall rules * add ability to optionally disable the default firewall rules that allow all internal traffic and SSH tunnels using Identity-Aware Proxy
- fix minor typos - document custom firewall rules and use of CFT documentation for full structure of input variable
c7ee467 to
18c7118
Compare
nick-stroud
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have manually tested the
hpc-small.yamlexample and observed that the default firewall rules are still created. I have also manually submitted integration group 4 build and observed success. I believe only groups 3 and 4 test this module's functionality.Submission Checklist
pre-commit install)make tests)