Skip to content

Conversation

@tpdownes
Copy link
Contributor

@tpdownes tpdownes commented Jul 6, 2022

  • update to CFT Cloud Router module 2.0
  • add support for custom firewall rules
  • optionally enable/disable default firewall rules
  • add support for secondary IP ranges in VPC as "passthrough" variable
  • update documentation to direct users for information on detailed structure of the complex object/map variables

I have manually tested the hpc-small.yaml example and observed that the default firewall rules are still created. I have also manually submitted integration group 4 build and observed success. I believe only groups 3 and 4 test this module's functionality.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes changed the title Feat vpc updates Maintenance of VPC module Jul 6, 2022
@tpdownes tpdownes requested a review from nick-stroud July 6, 2022 22:12
nick-stroud
nick-stroud previously approved these changes Jul 7, 2022
@tpdownes
Copy link
Contributor Author

tpdownes commented Jul 7, 2022

One of your comments prompted a real change to keep the distinct firewall_rules module until we adopt Terraform 1.1+. While doing this, addressed the nits. The real change required re-writing the git history so there is a force push here. Hopefully conversations not too impacted.

tpdownes added 2 commits July 7, 2022 14:43
* add input variable to supply custom firewall rules
* add ability to optionally disable the default firewall rules that
  allow all internal traffic and SSH tunnels using Identity-Aware Proxy
- fix minor typos
- document custom firewall rules and use of CFT documentation for full
  structure of input variable
@tpdownes tpdownes force-pushed the feat_vpc_updates branch from c7ee467 to 18c7118 Compare July 7, 2022 19:44
@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Jul 7, 2022
@tpdownes tpdownes merged commit 037e0e1 into GoogleCloudPlatform:develop Jul 7, 2022
@tpdownes tpdownes deleted the feat_vpc_updates branch July 7, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants