Skip to content

Fix link to login node in modules README #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heyealex merged 1 commit into from
Jul 12, 2022
Merged

Fix link to login node in modules README #407

heyealex merged 1 commit into from
Jul 12, 2022

Conversation

@heyealex
Copy link
Contributor

@heyealex heyealex commented Jul 12, 2022

Fixing a link that pointed to .../scheduler/-login-node rather than .../scheduler/-login

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@heyealex heyealex requested a review from nick-stroud July 12, 2022 18:26
tpdownes
tpdownes approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick-stroud was suddenly on the wrong end of a lot of review requests. I approve this PR.

@tpdownes tpdownes assigned tpdownes and unassigned nick-stroud Jul 12, 2022
@tpdownes tpdownes removed the request for review from nick-stroud July 12, 2022 18:31
@heyealex heyealex merged commit 1d3f365 into GoogleCloudPlatform:develop Jul 12, 2022
@heyealex heyealex deleted the bugfix/login-readme-link branch July 27, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tpdownes tpdownes tpdownes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tpdownes tpdownes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heyealex @tpdownes @nick-stroud