Conversation
bernardhan33
approved these changes
Mar 11, 2024
Collaborator
bernardhan33
left a comment
There was a problem hiding this comment.
This is great for an initial pass. For next steps it might be good to understand
- With an existing number (<=cpu count) of processes doing the download, the performance improvement of further parallelizing the download.
- For frameworks such as PyTorch, with an existing number (<=cpu count) of workers doing the download, the performance of further parallelizing the download. There, we might not see that much of a performance improvement due to the "batch_size" and "prefetching".
Collaborator
Author
Yes, getting a full understanding of the actual impact of different values will be essential to figuring out some sort of "recommendation" function in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple parallel bench with instructions to run in comments.