Conversation
bernardhan33
approved these changes
Mar 12, 2024
Collaborator
bernardhan33
left a comment
bernardhan33
left a comment
There was a problem hiding this comment.
"Parallel processes are not functional with daemonic workers" --> Could you provide more context there? What are "daemonic workers" and what happens there?
bernardhan33
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel processes are not functional with daemonic workers, so threading must be used to integrate download parallelization with real ML workloads. When running on an already-distributed system (e.g. executing with Ray or DLIO managing parallelization) the daemons executing each portion of the training will not allow further sub-processes to be spun up.