Conversation
bernardhan33
approved these changes
Apr 1, 2024
MattIrv
approved these changes
Apr 1, 2024
Collaborator
MattIrv
left a comment
MattIrv
left a comment
There was a problem hiding this comment.
The linked Kokoro presubmit run doesn't seem to show individual test output and says there was an xml processing error. Would you have expected it to?
Collaborator
Author
I think kokoro config changes don't propagate with the CL, but i'm not 100% certain. Plan was to submit this and verify if it works on future runs. Shouldn't cause any harm to submit either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config so that per-test output is cleaner for presubmits.