Fix: Backticks being removed causing mysql queries to fail#91
Merged
hardikgu23 merged 3 commits intomainfrom Nov 14, 2024
Merged
Fix: Backticks being removed causing mysql queries to fail#91hardikgu23 merged 3 commits intomainfrom
hardikgu23 merged 3 commits intomainfrom
Conversation
mahyareb
requested changes
Nov 14, 2024
Collaborator
mahyareb
left a comment
mahyareb
left a comment
There was a problem hiding this comment.
Good find!
We actually shouldn’t modify / sanitize the sql at all. Could you just add an if statement here that skips all the sanitization if the prompt generator is the NOOP one. (What we use for SQLGen)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were removing ` from all sql queries before executing them causing some mysql queries to fail when table name consists of multiple words.
See examples here: https://dashboards.corp.google.com/embed/cloud_databases_nl2sql_dashboards_dash_specs_run_details?p=run_id:ee1e52bb-4a5e-4acf-bf2a-61c32c3b7f07
Skipping this step when prompt generator is NOOP