Override the expected converted Pub/Sub payload #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrobertson
force-pushed
the
override-expected-pubsub-conversion
branch
from
ed4580b to
66ac9e6
Compare
mtraver
reviewed
Apr 27, 2021
Contributor
mtraver
left a comment
mtraver
left a comment
There was a problem hiding this comment.
I like this overall but I'm not sure about the term "converted". The conformance tests are testing event conversion, but there's this other notion of converted events now and I think those unfamiliar will be confused. I don't have an alternative suggestion yet but I'll think on it.
matthewrobertson
force-pushed
the
override-expected-pubsub-conversion
branch
from
66ac9e6 to
45a28d9
Compare
There are multiple legacy Pub/Sub payload schemas. For example, see: - legacy_pubsub-legacy-output.json - pubsub_text-legacy-output.json When converting Cloud Events to legacy events there is no information in the CE that enables us to infer which schema to convert to. Unfortunately, this tool assumes the converted output will always match a corresponding unconverted payload, which isn't necessarily possible. This commit adds a mechanism to override the exepcted output when converting between event types and creates an override for converting legacy_pubsub test case
matthewrobertson
force-pushed
the
override-expected-pubsub-conversion
branch
from
45a28d9 to
60e92e4
Compare
mtraver
approved these changes
Apr 29, 2021
Contributor
mtraver
left a comment
mtraver
left a comment
There was a problem hiding this comment.
Alright looks good. I think the terminology is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple legacy Pub/Sub payload schemas. For example, see:
legacy_pubsub-legacy-output.jsonpubsub_text-legacy-output.jsonWhen converting Cloud Events to legacy events there is no information
in the CE that enables us to infer which schema to use for the conversion.
Unfortunately, this tool assumes the converted output will always match
a corresponding unconverted payload, which isn't necessarily possible.
This commit adds a mechanism to override the expected output when
converting between event types and creates an override for converting
the
legacy_pubsubtest case.