Correctly resolve function runtime classpath in Maven plugin. Fixes #30 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
changed the title
Contributor
Author
|
Any hope this will be merged? |
Contributor
|
Hi @graemerocher, it looks like we could get a couple reviews for this framework. I've sent a review request to the main maintainer. |
Contributor
Author
|
Thanks |
invoker/function-maven-plugin/src/main/java/com/google/cloud/functions/plugin/RunFunction.java
Outdated
Show resolved
Hide resolved
invoker/function-maven-plugin/src/main/java/com/google/cloud/functions/plugin/RunFunction.java
Outdated
Show resolved
Hide resolved
Member
eamonnmcmanus
left a comment
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Thanks! Sorry I missed this earlier. It looks fine apart from a couple of very minor things.
alvarosanchez
added a commit
to micronaut-projects/micronaut-core
that referenced
this pull request
Nov 10, 2020
So that it includes GoogleCloudPlatform/functions-framework-java#32
graemerocher
pushed a commit
to micronaut-projects/micronaut-core
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly builds the runtime classpath for the function. The current implementation only includes compile dependencies which is broken for all but the most trivial cases.