Conversation
googlebot
added
the
cla: yes
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
Nit: There's a mix of single and double quote usage. It might be nice to open a new issue to add a code formatter to this repo as well.
|
@busunkim96 I have a code formatter running for all PRs, which can be run locally using |
|
|
||
| return redirect(url_for('.view', book_id=book['id'])) | ||
|
|
||
| return render_template('form.html', action='Add', book={}) |
There was a problem hiding this comment.
Nit: should this be at the top, like so?
if request.method != 'POST':
return render_template(...)
...There was a problem hiding this comment.
I think it's more idiomatic for python as is, mostly because this is how the previous bookshelf was set up. So I'd prefer to leave it as-is
|
|
||
| return redirect(url_for('.view', book_id=book['id'])) | ||
|
|
||
| return render_template('form.html', action='Edit', book=book) |
There was a problem hiding this comment.
Same comment as above - should this be at the top?
4 participants
No description provided.