Conversation
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
=========================================
Coverage 69.91% 69.91%
Complexity 1237 1237
=========================================
Files 219 219
Lines 8796 8796
Branches 743 743
=========================================
Hits 6150 6150
Misses 2331 2331
Partials 315 315
Continue to review full report at Codecov.
|
Contributor
Author
Contributor
Author
|
Ping @akerekes |
Contributor
Author
|
Ping ping ping |
akerekes
approved these changes
Mar 2, 2017
Contributor
akerekes
left a comment
There was a problem hiding this comment.
What was the reason for this change?
Contributor
Author
|
The reason is general code safety. Last week I spent two days hunting down a flaky bug in a PR that occurred because the test was mutating internal private state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.