Skip to content

reduce public visibility#1495

Merged
elharo merged 4 commits intomasterfrom
i1467
Mar 2, 2017
Merged

reduce public visibility#1495
elharo merged 4 commits intomasterfrom
i1467

Conversation

@elharo
Copy link
Copy Markdown
Contributor

@elharo elharo commented Feb 28, 2017

No description provided.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1495 into master will not change coverage.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master    #1495   +/-   ##
=========================================
  Coverage     69.91%   69.91%           
  Complexity     1237     1237           
=========================================
  Files           219      219           
  Lines          8796     8796           
  Branches        743      743           
=========================================
  Hits           6150     6150           
  Misses         2331     2331           
  Partials        315      315
Impacted Files Coverage Δ Complexity Δ
...se/appengine/libraries/model/MavenCoordinates.java 95.12% <ø> (ø) 14 <0> (ø)
...eclipse/appengine/libraries/model/LibraryFile.java 100% <ø> (ø) 11 <0> (ø)
...gine/libraries/repository/M2RepositoryService.java 43.33% <33.33%> (ø) 5 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0968f78...4f631f3. Read the comment docs.

@elharo elharo requested a review from akerekes March 1, 2017 12:14
@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Mar 1, 2017

@akerekes

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Mar 1, 2017

Ping @akerekes

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Mar 2, 2017

Ping ping ping

Copy link
Copy Markdown
Contributor

@akerekes akerekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for this change?

@elharo
Copy link
Copy Markdown
Contributor Author

elharo commented Mar 2, 2017

The reason is general code safety. Last week I spent two days hunting down a flaky bug in a PR that occurred because the test was mutating internal private state.

@elharo elharo merged commit 5b26128 into master Mar 2, 2017
@elharo elharo deleted the i1467 branch March 2, 2017 15:38
@elharo elharo restored the i1467 branch March 7, 2017 16:21
@elharo elharo deleted the i1467 branch March 10, 2017 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants