Add HttpUtil test#1535
Merged
chanseokoh merged 3 commits intomasterfrom Mar 7, 2017
Merged
Conversation
elharo
reviewed
Mar 7, 2017
| private static final String LONG_PARAMETER = "Exception in thread \"main\"" | ||
| + " java.lang.IllegalArgumentException: Wrong argument!\n\tat B.main(B.java:73)"; | ||
|
|
||
| private static final Map<String, String> testParameters = new HashMap<String, String>() { |
Contributor
Author
There was a problem hiding this comment.
I realized I can't use the diamond syntax when I'm using the double-brace initialization. I could have used Guava, but this bundle is free of Guava, so I decided not to do so.
Now I think I'll change this to plain static initialization, because the double-brace initialization gives me the serial ID warning.
akerekes
approved these changes
Mar 7, 2017
Contributor
|
LGTM once the builds are successful |
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
============================================
+ Coverage 70.31% 70.47% +0.15%
+ Complexity 1302 1301 -1
============================================
Files 232 232
Lines 8942 8942
Branches 761 761
============================================
+ Hits 6288 6302 +14
+ Misses 2338 2321 -17
- Partials 316 319 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1437.