Skip to content

Add HttpUtil test#1535

Merged
chanseokoh merged 3 commits intomasterfrom
i1437-add-http-util-test
Mar 7, 2017
Merged

Add HttpUtil test#1535
chanseokoh merged 3 commits intomasterfrom
i1437-add-http-util-test

Conversation

@chanseokoh
Copy link
Copy Markdown
Contributor

Part of #1437.

private static final String LONG_PARAMETER = "Exception in thread \"main\""
+ " java.lang.IllegalArgumentException: Wrong argument!\n\tat B.main(B.java:73)";

private static final Map<String, String> testParameters = new HashMap<String, String>() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HashMap<>()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized I can't use the diamond syntax when I'm using the double-brace initialization. I could have used Guava, but this bundle is free of Guava, so I decided not to do so.

Now I think I'll change this to plain static initialization, because the double-brace initialization gives me the serial ID warning.

@akerekes
Copy link
Copy Markdown
Contributor

akerekes commented Mar 7, 2017

LGTM once the builds are successful

@chanseokoh chanseokoh merged commit 6b53237 into master Mar 7, 2017
@chanseokoh chanseokoh deleted the i1437-add-http-util-test branch March 7, 2017 19:22
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1535 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1535      +/-   ##
============================================
+ Coverage     70.31%   70.47%   +0.15%     
+ Complexity     1302     1301       -1     
============================================
  Files           232      232              
  Lines          8942     8942              
  Branches        761      761              
============================================
+ Hits           6288     6302      +14     
+ Misses         2338     2321      -17     
- Partials        316      319       +3
Impacted Files Coverage Δ Complexity Δ
...clipse/appengine/facets/NonSystemJobSuspender.java 83.78% <0%> (-5.41%) 9% <0%> (-1%)
.../tools/eclipse/test/util/project/ProjectUtils.java 79.59% <0%> (-1.03%) 18% <0%> (-1%)
...d/tools/eclipse/test/util/http/TestHttpServer.java 93.87% <0%> (+2.04%) 12% <0%> (ø)
...gle/cloud/tools/eclipse/usagetracker/HttpUtil.java 89.79% <0%> (+32.65%) 7% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78772ab...7e57beb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants