Skip to content

Update for AERI v2.0.4 and regenerate .targets#1541

Merged
briandealwis merged 2 commits intomasterfrom
aeri-2.0.4
Mar 7, 2017
Merged

Update for AERI v2.0.4 and regenerate .targets#1541
briandealwis merged 2 commits intomasterfrom
aeri-2.0.4

Conversation

@briandealwis
Copy link
Copy Markdown
Member

No description provided.

<import feature="org.eclipse.wst.web_ui.feature" version="3.7.1.v201602111638" match="greaterOrEqual"/>
</requires>

<!-- appengine-plugins-core -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to leave this comment here. I was confused once why we don't have this com.google.cloud.tools.appengine in my workbench.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the feature editor to remove the dependency; I'll restore it.

<unit id="org.eclipse.jetty.servlet" version="9.4.0.v20161208"/>
<unit id="org.eclipse.jetty.server" version="9.4.0.v20161208"/>
<unit id="org.eclipse.jetty.util" version="9.4.0.v20161208"/>
<unit id="ch.qos.logback.slf4j" version="1.0.7.v201505121915"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to this issue?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but this dependency shouldn't have been here as I previously moved Logback to be resolved from the Orbit repository (which you can see further below).

<unit id="org.eclipse.epp.logging.aeri.feature.feature.group" version="2.0.3.v20160923-1310"/>
<unit id="org.eclipse.epp.logging.aeri.feature.source.feature.group" version="2.0.3.v20160923-1310"/>
<unit id="org.eclipse.epp.logging.aeri.feature.feature.group" version="2.0.4.v20170307-1435"/>
<unit id="org.eclipse.epp.logging.aeri.feature.source.feature.group" version="2.0.4.v20170307-1435"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't change this for Neon or Oxygen. (They still have entries with "2.0.3".) Is this intended?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AERI is shipped as part of the Neon and Oxygen builds, and they'll be updated for the next milestone. I think we want to build with the shipped versions.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 7, 2017

Codecov Report

Merging #1541 into master will decrease coverage by -0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1541      +/-   ##
============================================
- Coverage     70.29%   70.25%   -0.05%     
- Complexity     1299     1323      +24     
============================================
  Files           232      233       +1     
  Lines          8935     9043     +108     
  Branches        762      782      +20     
============================================
+ Hits           6281     6353      +72     
- Misses         2336     2371      +35     
- Partials        318      319       +1
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/tools/eclipse/util/io/HttpUtil.java 57.14% <0%> (ø) 6% <0%> (?)
...loud/tools/eclipse/swtbot/SwtBotTreeUtilities.java 18.75% <0%> (+1.04%) 5% <0%> (ø)
...ols/eclipse/usagetracker/AnalyticsPingManager.java 58.62% <0%> (+2.62%) 32% <0%> (+16%)
...le/cloud/tools/eclipse/util/io/FileDownloader.java 78% <0%> (+8.55%) 8% <0%> (+2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d908505...1d0c1d2. Read the comment docs.

@briandealwis briandealwis merged commit 39c0969 into master Mar 7, 2017
@briandealwis briandealwis deleted the aeri-2.0.4 branch March 7, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants