Update for AERI v2.0.4 and regenerate .targets#1541
Conversation
| <import feature="org.eclipse.wst.web_ui.feature" version="3.7.1.v201602111638" match="greaterOrEqual"/> | ||
| </requires> | ||
|
|
||
| <!-- appengine-plugins-core --> |
There was a problem hiding this comment.
I think it's okay to leave this comment here. I was confused once why we don't have this com.google.cloud.tools.appengine in my workbench.
There was a problem hiding this comment.
I used the feature editor to remove the dependency; I'll restore it.
| <unit id="org.eclipse.jetty.servlet" version="9.4.0.v20161208"/> | ||
| <unit id="org.eclipse.jetty.server" version="9.4.0.v20161208"/> | ||
| <unit id="org.eclipse.jetty.util" version="9.4.0.v20161208"/> | ||
| <unit id="ch.qos.logback.slf4j" version="1.0.7.v201505121915"/> |
There was a problem hiding this comment.
Is this related to this issue?
There was a problem hiding this comment.
No, but this dependency shouldn't have been here as I previously moved Logback to be resolved from the Orbit repository (which you can see further below).
| <unit id="org.eclipse.epp.logging.aeri.feature.feature.group" version="2.0.3.v20160923-1310"/> | ||
| <unit id="org.eclipse.epp.logging.aeri.feature.source.feature.group" version="2.0.3.v20160923-1310"/> | ||
| <unit id="org.eclipse.epp.logging.aeri.feature.feature.group" version="2.0.4.v20170307-1435"/> | ||
| <unit id="org.eclipse.epp.logging.aeri.feature.source.feature.group" version="2.0.4.v20170307-1435"/> |
There was a problem hiding this comment.
You didn't change this for Neon or Oxygen. (They still have entries with "2.0.3".) Is this intended?
There was a problem hiding this comment.
AERI is shipped as part of the Neon and Oxygen builds, and they'll be updated for the next milestone. I think we want to build with the shipped versions.
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
============================================
- Coverage 70.29% 70.25% -0.05%
- Complexity 1299 1323 +24
============================================
Files 232 233 +1
Lines 8935 9043 +108
Branches 762 782 +20
============================================
+ Hits 6281 6353 +72
- Misses 2336 2371 +35
- Partials 318 319 +1
Continue to review full report at Codecov.
|
No description provided.