Order our New menu to distinguish App Engine Standard from Flexible#1542
Merged
briandealwis merged 1 commit intomasterfrom Mar 9, 2017
Merged
Order our New menu to distinguish App Engine Standard from Flexible#1542briandealwis merged 1 commit intomasterfrom
briandealwis merged 1 commit intomasterfrom
Conversation
chanseokoh
approved these changes
Mar 7, 2017
Contributor
chanseokoh
left a comment
There was a problem hiding this comment.
I wonder it's better to add a .separator suffix to the separator names.
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
============================================
- Coverage 70.31% 70.28% -0.04%
+ Complexity 1302 1300 -2
============================================
Files 232 232
Lines 8942 8942
Branches 761 761
============================================
- Hits 6288 6285 -3
- Misses 2338 2339 +1
- Partials 316 318 +2
Continue to review full report at Codecov.
|
elharo
reviewed
Mar 7, 2017
Contributor
elharo
left a comment
There was a problem hiding this comment.
Let's not use a separator. The maven and non-maven standard projects are likely to be combined here.
Contributor
|
I'd use the separator until they're get combined. |
Member
Author
|
I'm with @akerekes — I found I was having to hunt more without the separator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds placeholders to our GCP Toolbar's New menu to separate Standard options from Flexible.
Fixes #1536