Skip to content

Order our New menu to distinguish App Engine Standard from Flexible#1542

Merged
briandealwis merged 1 commit intomasterfrom
i1536
Mar 9, 2017
Merged

Order our New menu to distinguish App Engine Standard from Flexible#1542
briandealwis merged 1 commit intomasterfrom
i1536

Conversation

@briandealwis
Copy link
Copy Markdown
Member

Adds placeholders to our GCP Toolbar's New menu to separate Standard options from Flexible.

screen shot 2017-03-07 at 1 37 35 pm

Fixes #1536

Copy link
Copy Markdown
Contributor

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder it's better to add a .separator suffix to the separator names.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 7, 2017

Codecov Report

Merging #1542 into master will decrease coverage by -0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1542      +/-   ##
============================================
- Coverage     70.31%   70.28%   -0.04%     
+ Complexity     1302     1300       -2     
============================================
  Files           232      232              
  Lines          8942     8942              
  Branches        761      761              
============================================
- Hits           6288     6285       -3     
- Misses         2338     2339       +1     
- Partials        316      318       +2
Impacted Files Coverage Δ Complexity Δ
...clipse/appengine/facets/NonSystemJobSuspender.java 83.78% <0%> (-5.41%) 9% <0%> (-1%)
.../tools/eclipse/test/util/project/ProjectUtils.java 79.59% <0%> (-1.03%) 18% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78772ab...5b1484d. Read the comment docs.

Copy link
Copy Markdown
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use a separator. The maven and non-maven standard projects are likely to be combined here.

@akerekes
Copy link
Copy Markdown
Contributor

akerekes commented Mar 7, 2017

I'd use the separator until they're get combined.

@briandealwis
Copy link
Copy Markdown
Member Author

I'm with @akerekes — I found I was having to hunt more without the separator.

@briandealwis briandealwis merged commit 2fc1a33 into master Mar 9, 2017
@briandealwis briandealwis deleted the i1536 branch March 9, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants