Skip to content

Fix build hang on .validation.test#1553

Merged
chanseokoh merged 22 commits intomasterfrom
i1527-build-error-code-143
Mar 8, 2017
Merged

Fix build hang on .validation.test#1553
chanseokoh merged 22 commits intomasterfrom
i1527-build-error-code-143

Conversation

@chanseokoh
Copy link
Copy Markdown
Contributor

Fixes #1527.

About org.eclispe.platform: I had originally thought using org.eclipse.platform instead of org.eclipse.rcp somehow eliminated the build hang (#1484 (comment)), but it wasn't the case, so I am reverting that.

@chanseokoh chanseokoh requested a review from abbiefarr-zz March 8, 2017 16:41
@chanseokoh chanseokoh requested review from briandealwis and removed request for abbiefarr-zz March 8, 2017 16:42
@chanseokoh
Copy link
Copy Markdown
Contributor Author

FTR, one build failure above is due to a different reason.

Copy link
Copy Markdown
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

private static final IProjectFacetVersion APPENGINE_STANDARD_FACET_VERSION_1 =
ProjectFacetsManager.getProjectFacet(AppEngineStandardFacet.ID).getVersion("1");

private static final List<IProjectFacetVersion> facetsToInstall = Arrays.asList(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't required previously?

Copy link
Copy Markdown
Contributor Author

@chanseokoh chanseokoh Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was working fine previously (which didn't have the marker checking). The facets are for actually triggering validation in the IDE when a file is open in an editor. It looks like the project needs to be an App Engine project to trigger it (and the file name is appengine-web.xml).

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 8, 2017

Codecov Report

Merging #1553 into master will increase coverage by 0.51%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #1553      +/-   ##
============================================
+ Coverage     70.53%   71.05%   +0.51%     
- Complexity     1307     1328      +21     
============================================
  Files           233      233              
  Lines          8995     9139     +144     
  Branches        765      785      +20     
============================================
+ Hits           6345     6494     +149     
- Misses         2326     2327       +1     
+ Partials        324      318       -6
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/tools/eclipse/ui/util/WorkbenchUtil.java 64% <50%> (-8%) 4 <0> (ø)
.../tools/eclipse/test/util/project/ProjectUtils.java 80.61% <0%> (+1.02%) 19% <0%> (+1%)
...ipse/appengine/libraries/model/LibraryFactory.java 72.83% <0%> (+1.23%) 17% <0%> (+1%)
...gine/deploy/ui/StandardDeployPreferencesPanel.java 87.84% <0%> (+2.03%) 33% <0%> (+10%)
...m/google/cloud/tools/eclipse/ui/util/FontUtil.java 79.16% <0%> (+2.69%) 6% <0%> (+1%)
...tools/eclipse/projectselector/ProjectSelector.java 92.42% <0%> (+2.76%) 9% <0%> (ø)
...e/cloud/tools/eclipse/appengine/libraries/Pom.java 86.74% <0%> (+4.65%) 15% <0%> (+2%)
...m/google/cloud/tools/eclipse/util/NatureUtils.java 88.88% <0%> (+11.11%) 5% <0%> (+1%)
...appengine/facets/NonSystemJobScheduleListener.java 100% <0%> (+12.5%) 7% <0%> (+1%)
...pengine/validation/AbstractXmlSourceValidator.java 92% <0%> (+40%) 8% <0%> (+4%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b38726...5ab51d5. Read the comment docs.

@chanseokoh chanseokoh merged commit be6a763 into master Mar 8, 2017
@chanseokoh chanseokoh deleted the i1527-build-error-code-143 branch March 8, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants