Fix build hang on .validation.test#1553
Conversation
|
FTR, one build failure above is due to a different reason. |
| private static final IProjectFacetVersion APPENGINE_STANDARD_FACET_VERSION_1 = | ||
| ProjectFacetsManager.getProjectFacet(AppEngineStandardFacet.ID).getVersion("1"); | ||
|
|
||
| private static final List<IProjectFacetVersion> facetsToInstall = Arrays.asList( |
There was a problem hiding this comment.
This wasn't required previously?
There was a problem hiding this comment.
The test was working fine previously (which didn't have the marker checking). The facets are for actually triggering validation in the IDE when a file is open in an editor. It looks like the project needs to be an App Engine project to trigger it (and the file name is appengine-web.xml).
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
============================================
+ Coverage 70.53% 71.05% +0.51%
- Complexity 1307 1328 +21
============================================
Files 233 233
Lines 8995 9139 +144
Branches 765 785 +20
============================================
+ Hits 6345 6494 +149
- Misses 2326 2327 +1
+ Partials 324 318 -6
Continue to review full report at Codecov.
|
Fixes #1527.
About
org.eclispe.platform: I had originally thought usingorg.eclipse.platforminstead oforg.eclipse.rcpsomehow eliminated the build hang (#1484 (comment)), but it wasn't the case, so I am reverting that.