Make sure "Run As" > "App Engine" shows only on App Engine projects.#1560
Merged
chanseokoh merged 7 commits intomasterfrom Mar 9, 2017
Merged
Make sure "Run As" > "App Engine" shows only on App Engine projects.#1560chanseokoh merged 7 commits intomasterfrom
chanseokoh merged 7 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
===========================================
+ Coverage 70.89% 70.9% +0.01%
Complexity 1321 1321
===========================================
Files 233 233
Lines 9002 9002
Branches 767 767
===========================================
+ Hits 6382 6383 +1
+ Misses 2300 2299 -1
Partials 320 320
Continue to review full report at Codecov.
|
Contributor
Author
|
Asking @briandealwis to review, since he initially set up the enablement conditions. |
briandealwis
reviewed
Mar 9, 2017
Member
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
I greatly appreciate the tests!
| </with> | ||
| <with variable="activeEditorInput"> | ||
| <adapt type="org.eclipse.core.resources.IFile"> | ||
| <with variable="selection"> |
Member
There was a problem hiding this comment.
We can drop this outer <with variable="selection"> and just use the <iterate>…</iterate> on value that's passed in (that is likely — but not necessarily — the selection).
Contributor
Author
There was a problem hiding this comment.
Cool, it does work without <with>.
elharo
reviewed
Mar 9, 2017
| } | ||
|
|
||
| // We need regex matching, since the actual menu name is "<number> App Engine". | ||
| private boolean appEngineMenuExists(IProject project) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1556, per #1556 (comment).