Don't ignore case in xml validation#1590
Conversation
|
What about |
|
It's changed in another PR, but I can change it here too |
There was a problem hiding this comment.
LGTM.
It's changed in another PR, but I can change it here too.
Thanks. This PR should be self-contained, independent of other PRs, because for example, other PRs could be abandoned or rolled back. It's also necessary to maintain correct commit history.
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
============================================
+ Coverage 71.04% 71.27% +0.23%
- Complexity 1334 1355 +21
============================================
Files 236 236
Lines 9068 9170 +102
Branches 779 802 +23
============================================
+ Hits 6442 6536 +94
- Misses 2300 2305 +5
- Partials 326 329 +3
Continue to review full report at Codecov.
|
elharo
left a comment
There was a problem hiding this comment.
For a bug like this, we want a test that fails before the PR and passes after.
Fix #1581
@chanseokoh @elharo