Ensure WEB-INF directory exists before creating appengine-web.xml#2251
Ensure WEB-INF directory exists before creating appengine-web.xml#2251briandealwis merged 2 commits intomasterfrom
Conversation
| } | ||
| if (!webInfDir.exists()) { | ||
| ResourceUtils.createFolders(webInfDir, progress.newChild(1)); | ||
| } |
There was a problem hiding this comment.
Something seems off. We call ResourceUtils.createFolders(webInfDir, ...) above.
There was a problem hiding this comment.
Good point :-) In this case, webInfDir was not null.
Codecov Report
@@ Coverage Diff @@
## master #2251 +/- ##
============================================
+ Coverage 68.56% 68.64% +0.08%
- Complexity 1999 2013 +14
============================================
Files 324 324
Lines 12778 12838 +60
Branches 1227 1250 +23
============================================
+ Hits 8761 8813 +52
- Misses 3531 3533 +2
- Partials 486 492 +6
Continue to review full report at Codecov.
|
chanseokoh
left a comment
There was a problem hiding this comment.
I see. So the WTP facet settings (the virtual component) have the WEB-INF directory, but the directory actually doesn't exist, right?
|
I don't quite know how I got into this situation, as the |
Fixes #2250