Skip to content

Ensure WEB-INF directory exists before creating appengine-web.xml#2251

Merged
briandealwis merged 2 commits intomasterfrom
i2250
Aug 9, 2017
Merged

Ensure WEB-INF directory exists before creating appengine-web.xml#2251
briandealwis merged 2 commits intomasterfrom
i2250

Conversation

@briandealwis
Copy link
Copy Markdown
Member

Fixes #2250

}
if (!webInfDir.exists()) {
ResourceUtils.createFolders(webInfDir, progress.newChild(1));
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems off. We call ResourceUtils.createFolders(webInfDir, ...) above.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point :-) In this case, webInfDir was not null.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2017

Codecov Report

Merging #2251 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2251      +/-   ##
============================================
+ Coverage     68.56%   68.64%   +0.08%     
- Complexity     1999     2013      +14     
============================================
  Files           324      324              
  Lines         12778    12838      +60     
  Branches       1227     1250      +23     
============================================
+ Hits           8761     8813      +52     
- Misses         3531     3533       +2     
- Partials        486      492       +6
Impacted Files Coverage Δ Complexity Δ
...appengine/facets/StandardFacetInstallDelegate.java 86.53% <100%> (ø) 6 <0> (ø) ⬇️
.../appengine/localserver/launching/LaunchHelper.java 45.67% <0%> (-1.24%) 15% <0%> (-1%)
...calserver/server/LocalAppEngineServerDelegate.java 78.98% <0%> (+5.78%) 49% <0%> (+15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddca106...da1f69d. Read the comment docs.

Copy link
Copy Markdown
Contributor

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. So the WTP facet settings (the virtual component) have the WEB-INF directory, but the directory actually doesn't exist, right?

@briandealwis
Copy link
Copy Markdown
Member Author

I don't quite know how I got into this situation, as the test-projects/springboot-appengine-standard.zip does contain a WEB-INF/appengine-web.xml. I don't recall removing the WEB-INF directory.

@briandealwis briandealwis merged commit 9d651f4 into master Aug 9, 2017
@briandealwis briandealwis deleted the i2250 branch August 9, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants